Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: relink_namespaces handles attributes properly #2310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: relink_namespaces handles attributes properly #2310

wants to merge 2 commits into from

Commits on Aug 30, 2022

  1. test: add coverage for HTML5 attribute namespace behavior 

    This corresponds to the code added in 7b3c972

Note also that this commit adds the same test for HTML4, commented out
because it currently fails, that we will make pass in the next few
commits.
    @flavorjones
    flavorjones committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    90b3dd0 View commit details
    Browse the repository at this point in the history

  2. fix: skip relinking namespaces in HTML4/5 documents 

    Also fix both implementations of relink_namespaces to not skip
attributes when the node itself doesn't have a namespace.

Finally, the private method
XML::Node#add_child_node_and_reparent_attrs is no longer needed after
fixing relink_namespaces, so this commit essentially reverts 9fd03d8.
    @flavorjones
    flavorjones committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    8dde633 View commit details
    Browse the repository at this point in the history