-
-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix namespace reparenting issue #2494. #2495
base: main
Are you sure you want to change the base?
Conversation
ff0357e
to
3b4c926
Compare
I've kicked off CI. |
3b4c926
to
c3e6b7e
Compare
I've rebased onto current |
Looks like this PR breaks some downstream users of Nokogiri. Would you be able to take a look at what's going on there, please? |
I think I might be able to take a look, yeah. Let me see which ones get broken. I couldn't find any breaks in the main tests but maybe I didn't run some. |
Note that the libxml2 maintainer pointed out in #2919 that |
What problem is this PR intended to solve?
This PR is intended to address #2494, issues with the reparenting of nodes with prefix collisions.
Closes #2494
Have you included adequate test coverage?
I've added a test as part of the namespace testing under
test/xml/test_namespace.rb
.Does this change affect the behavior of either the C or the Java implementations?
C implementations are corrected, the java implementation does not suffer from this issue (tests pass correctly with no code change).