Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jruby: use a modern c14n library #2547

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

jruby: use a modern c14n library #2547

wants to merge 3 commits into from
+113 −5,433

Commits on Oct 16, 2022

  1. test: backfill better coverage for canonicalize with a block

    @flavorjones
    flavorjones committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    a0500f7 View commit details
    Browse the repository at this point in the history

  2. test: failing multibyte unicode test 

    From #2410
    @flavorjones
    flavorjones committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    7b7b1d5 View commit details
    Browse the repository at this point in the history

  3. feat: migrate to santuario c14n 

    instead of using a patched fork of apache c14n from 2013

This commit removes the block parameter from the JRuby API, because

a) it didn't previously work the same as CRuby/libxml2 (see earlier
commit that introduces block test coverage that failed)

b) with the mainline c14n library we can't hack it to support even the
broken callback semantics and would be forced to implement something
complicated ourselves

Given I'm not confident that C14n is widely-used anyway, removing a
misfeature like this doesn't seem like a controversial decision.

So, questions to the JRuby contributors:

Q1: Are we OK with all these new dependencies getting pulled in?
Q2: There's some Log4J warning messages being emitted at runtime that
    I'm not sure whether or how to quash. Any ideas?
    @flavorjones
    flavorjones committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    654f008 View commit details
    Browse the repository at this point in the history