feat: Nokogiri::HTML5::Builder
#3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-html5-builder
branch
from
47a4d8e to
9d8caee
Compare
which behaves like HTML4::Builder but returns an HTML5::Document
flavorjones
force-pushed
the
flavorjones-html5-builder
branch
from
9d8caee to
3cb06c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Provide a Builder class that generates HTML5 documents.
The construction behavior is identical to HTML4::Builder, but HTML5 documents serialize according to the HTML5 standard (see
xml_node.c:output_node()).Have you included adequate test coverage?
Added tests are a copied-and-modified version of the HTML4::Builder tests.
Does this change affect the behavior of either the C or the Java implementations?
The Java implementation still does not support HTML5.