dev: extconf supports --gumbo-dev #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
added a commit
that referenced
this pull request
Jun 7, 2024
- remove the `rebuild-libgumbo` target which is probably not needed once #3220 is merged - avoid downloading googletest when just running `rake compile` - update the Manifest check to ignore new gumbo-parser/ files - simplify the 'host' variable in gumbo.rake, since we're only using it in development (and not cross-compiling)
flavorjones
added a commit
that referenced
this pull request
Jun 7, 2024
- remove the `rebuild-libgumbo` target which is probably not needed once #3220 is merged - avoid downloading googletest when just running `rake compile` - update the Manifest check to ignore new gumbo-parser/ files - simplify the 'host' variable in gumbo.rake, since we're only using it in development (and not cross-compiling)
flavorjones
added a commit
that referenced
this pull request
Jun 7, 2024
- remove the `rebuild-libgumbo` target which is probably not needed once #3220 is merged - avoid downloading googletest when just running `rake compile` - update the Manifest check to ignore new gumbo-parser/ files - simplify the 'host' variable in gumbo.rake, since we're only using it in development (and not cross-compiling)
flavorjones
added a commit
that referenced
this pull request
Jun 7, 2024
- remove the `rebuild-libgumbo` target which is probably not needed once #3220 is merged - avoid downloading googletest when just running `rake compile` - update the Manifest check to ignore new gumbo-parser/ files - simplify the 'host' variable in gumbo.rake, since we're only using it in development (and not cross-compiling) - put back the libgumbo $libs, $LIBPATH, and include flags modifications
flavorjones
added a commit
that referenced
this pull request
Jun 8, 2024
- remove the `rebuild-libgumbo` target which is probably not needed once #3220 is merged - avoid downloading googletest when just running `rake compile` - update the Manifest check to ignore new gumbo-parser/ files - simplify the 'host' variable in gumbo.rake, since we're only using it in development (and not cross-compiling) - put back the libgumbo $libs, $LIBPATH, and include flags modifications - make sure libgumbo is built static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Enable a faster development feedback loop when working on libgumbo. See notes in CONTRIBUTING.md for how to use it.
Closes #2718