enable libxml2 "legacy" libraries #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
3168-libxml2-legacy
branch
from
c34dbac to
3be3004
Compare
this is insufficient coverage, there are other methods that likely support decompression. this test is only intended to demonstrate an instance of zlib/lzma support, relative to libxml2's "legacy" option in v2.13.0.
flavorjones
force-pushed
the
3168-libxml2-legacy
branch
from
3be3004 to
bdcfdac
Compare
- zlib - liblzma - HTTP libxml2 v2.13.0 turned these off by default, so this commit re-enables them. I'm proposing to support this functionality in Nokogiri 1.x releases, but remove it (possibly with an option to re-enable it) in Nokogiri 2.x. See #3168 for discussion.
flavorjones
force-pushed
the
3168-libxml2-legacy
branch
from
bdcfdac to
46c1e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
libxml2 v2.13.0 disabled support for zlib, liblzma, and HTTP by default.
To avoid introducing a breaking change, this PR re-enables support for those features, see #3168 for discussion and a proposal to disable them in a future Nokogiri v2.0 release.
This PR also introduces a
extconf.rbflag--disable-xml2-legacyto disable these features for people who wish to.Also introduced is a boolean constant
Nokogiri::LIBXML_ZLIB_ENABLEDso that we can programmatically tell whether this support is present.Have you included adequate test coverage?
Yes, basic test coverage (not complete).
Does this change affect the behavior of either the C or the Java implementations?
This prevents a behavior change in the CRuby impl. Note that the Java implementation has never supported automatic decompression of content (like libxml2 does with zlib/lzma support).