fix: sax parser encoding overrides #3282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- xmlGetActualEncoding is an internal-only libxml2 function which we can't use (yet?) - the ctxt->input->encoding bit is no longer needed as of libxml 2.12
Previously, this functionality worked fine for `#parse_io` but didn't work for `#parse_memory`. This change introduces a new optional encoding parameter to `SAX::Parser#parse_memory` and `SAX::ParserContext.memory`, and makes sure to use that encoding or the one passed to the Parser's initializer. This change also makes optional the encoding_id parameter to `SAX::ParserContext.io`, which was previously required. Closes #918
to prepare for a big refactor
flavorjones
changed the title
flavorjones
force-pushed
the
918-sax-parser-encoding
branch
2 times, most recently
from
f561698
to
11f29a7
Compare
flavorjones
force-pushed
the
918-sax-parser-encoding
branch
from
11f29a7
to
de002ff
Compare
|
I don't like how this ended up, will open a different PR that unifies the two SAX::Parser classes and the two SAX::ParserContext classes, and fixes the encoding issues in a more fundamental way. |
|
See #3288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
XML::SAX::Parser#parse_memorynow accepts an optionalencodingargument. When not provided, the parser will fall back to the encoding passed to the initializer, and then fall back to autodetection.XML::SAX::ParserContext.memorynow accepts an optionalencoding_idargument. When not provided, the encoding will be autodetected.XML::SAX::ParserContext.io'sencoding_idargument is now optional, and when not provided will default to autodetecting the encoding.Closes #918
Have you included adequate test coverage?
Yes, added through test coverage for both XML and HTML4 sax parsers.
Does this change affect the behavior of either the C or the Java implementations?
Updated both implementations.