fix: sax parser encoding overrides #3282
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
XML::SAX::Parser#parse_memory
now accepts an optionalencoding
argument. When not provided, the parser will fall back to the encoding passed to the initializer, and then fall back to autodetection.XML::SAX::ParserContext.memory
now accepts an optionalencoding_id
argument. When not provided, the encoding will be autodetected.XML::SAX::ParserContext.io
'sencoding_id
argument is now optional, and when not provided will default to autodetecting the encoding.Closes #918
Have you included adequate test coverage?
Yes, added through test coverage for both XML and HTML4 sax parsers.
Does this change affect the behavior of either the C or the Java implementations?
Updated both implementations.