Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overhaul SAX::Parser encoding handling #3288

Merged
merged 6 commits into from
Jul 7, 2024
Merged

fix: overhaul SAX::Parser encoding handling #3288

merged 6 commits into from
Jul 7, 2024

Commits on Jul 7, 2024

  1. tidy: update test/*/sax/test_parser_context.rb to use minitest::spec

    @flavorjones
    flavorjones committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    28680f5 View commit details
    Browse the repository at this point in the history

  2. doc: correct "it's" to "its" as the possessive pronoun 

    "it's" means "it is", "its" means "belonging to it"
    @flavorjones
    flavorjones committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    1a93c71 View commit details
    Browse the repository at this point in the history

  3. feat: ClassResolver can find related classes in SAX namespaces 

    We'll use this in an upcoming commit to simplify the sax parsers
    @flavorjones
    flavorjones committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    a3c4ce2 View commit details
    Browse the repository at this point in the history

  4. ext(libxml): intro noko_xml_sax_parser_context_set_encoding() 

    and polyfill xmlSwitchEncodingName. We'll need this functionality in
the next commit.
    @flavorjones
    flavorjones committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    a887af9 View commit details
    Browse the repository at this point in the history

  5. fix: overhaul SAX::Parser encoding handling 

    Previously, encoding overrides were not implemented for
XML::SAX::Parser#parse_memory (as reported in #918) and
XML::SAX::Parser#parse_file.

However, this commit goes further and significantly simplifies and
unifies the two SAX::ParserContext implementations and the two
SAX::Parser implementations.

This commit also allows Encoding objects and encoding names to be
passed into the SAX::ParserContext methods, and the XML memory and
file methods now accept and properly use passed encodings.

Finally, this commit also backfills a lot of test coverage for the XML
and the HTML4 sax parser encoding.

Closes #918
    @flavorjones
    flavorjones committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    35596e7 View commit details
    Browse the repository at this point in the history

  6. doc: update CHANGELOG with "notable changes" for v1.17

    @flavorjones
    flavorjones committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    f67b294 View commit details
    Browse the repository at this point in the history