ext: update to rake-compiler-dock v1.6.0, ship both GNU and Musl native gems #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
flavorjones
force-pushed
the
flavorjones-update-to-rcd-1.6.0
branch
2 times, most recently
from
d219046 to
0221757
Compare
flavorjones
changed the title
flavorjones
force-pushed
the
flavorjones-update-to-rcd-1.6.0
branch
2 times, most recently
from
cb61fef to
ab3b9bc
Compare
Also: - matrix the linux and darwin native install tests - add a "install on setup-ruby" test - some general CI cleanup
flavorjones
force-pushed
the
flavorjones-update-to-rcd-1.6.0
branch
from
ab3b9bc to
3c0d202
Compare
flavorjones
added a commit
that referenced
this pull request
Dec 16, 2024
**What problem is this PR intended to solve?** Over time, we've accumulated a couple of hacks specifically aimed at improving the compatibility of the `-linux` native gem on Musl systems. With #3375 we're building separate `-linux-gnu` and `-linux-musl` gems, so these hacks should no longer be needed. Let's remove them. **Have you included adequate test coverage?** We're testing on a matrix that includes Musl systems, so existing coverage should be adequate. **Does this change affect the behavior of either the C or the Java implementations?** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Update rake-compiler-dock to the v1.6.0 version that drops manylinux before we move on to a v1.7.0 version that will presumably support Ruby 3.4.
As a result of the change from a manylinux image patched to be less-musl-compatible, we're also forced to start shipping separate GNU and Musl gems (see crash log when running the generic linux gem on musl).
Have you included adequate test coverage?
Existing coverage is sufficient.
Does this change affect the behavior of either the C or the Java implementations?
N/A