deploy staging -> master #1355
Merged
deploy staging -> master #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bt + improve performance (#1323) * refactor UserProfilePicture to remove styled-components + use BEM + fix layering issues * add isMessageToTheBandReaction helper * add isReactionCreatedBy helper * refactor reactions related code into UserReactions component * move utils/reactions -> types/reactions + update references * rename Reactions -> ReactionsData * rename ReactionsData -> AllReactions * rename MessageToTheBandReaction / chatMessageAsTextReaction / isMessageToTheBandReaction -> TextReaction / chatMessageAsTextReaction / isTextReaction * refactor static createReaction func outside of Audience component * refactor static burningReactions filter outside of Audience component * refactor createReaction into utils/reactions + add createEmojiReaction / createTextReaction + de-dupe usages * export TextReactionType const + use it across the app * add ReactionData type * add isEmojiReaction type predicate helper * rename AllReactions -> EmojiReactions * add reactionsDataMapReducer + EmojiReactionsMap * Remove ReactionsTextMap + inline it's data directly into EmojiReactions * add @debt comment to CallOutMessageForm * add uniqueEmojiReactionsDataMapReducer * add DisplayEmojiReaction component + refactor UserReactions to be more efficient * useMemo the filters/etc used to produce userShoutout / renderedEmojiReactions * refactor useReactions to optionally filter for just a single user * refactor useReactions with temporary hacky workaround to avoid having to create a composite index in firestore * leverage the functionality in useReactions to filter userReactions in UserReactions component * refactor UserProfilePicture to use named rather than default export + updated usages * use solid white background colour for shoutouts * add @debt comment to firebase subscription in Audience component * refactor avatarUrl to take named props * add useImage hook + use it in place of our previous image fallback handling * comment out useImage + add @debt comment * move useImage to src/hooks * refactor UserReactions to wrap the content it's adding reactions to + tweak reaction styles * add @debt comment to improve Audio usage * add z-indexes for UserReactions * minimize the scope of useReactions useEffect deps * add isBaseReaction / isReaction + improve isEmojiReaction / isTextReaction * add react-use * rename useReactions.ts -> useReactions.tsx * rename useReactions -> useReactionsLegacy * rename containerStyles -> containerClasses in UserAvatar component * fix merge issue * improve types for isTruthy to make it a type predicate + exclude null/undefined * refactor isBaseReaction to fix TypeScript error * refactor TemplateWrapper to use WithId<AnyVenue> + cleanup unneeded undefined check * add ReactionsProvider / useReactionsContext + new context based version of useReactions * refactor UserReactions component to use useReactions instead of useReactionsLegacy * fix Audience component to not try to load undefined as a background image * rename hooks/useReactions.tsx -> hooks/reactions.tsx * Cleanup unneeded styles in MapPartygoerOverlay + remove now unused avatarStyle prop from UserProfilePicture * Refactor inline styles into scss for MapPartygoerOverlay + add containerClassName prop to UserProfilePicture * refactor remaining inline styles into scss for MapPartygoerOverlay (including using css vars) * remove now unused containerStyle prop from UserProfilePicture * move UserReactions into components/molecules * cleanup/polish naming/styles/etc * add userId export to useUser hook * use var for white colour in scss * refactor Audience to use userId / userWithId better * Fix audience to return null instead of an empty fragment * remove unneeded ?? null in ReactionList as React (doesn't) render undefined in the same way * refactor UserProfilePicture to use useCss + vars for the avatar url * remove unused venueId prop from UserReactions + UserProfilePicture * refactor UserAvatar to accept optional WithId<User> instead of avatarSrc (string) + refactor related usages to support it * refactor a whole bunch of things to allow UseProfilePicture to use UserAvatar + various semi-related changes * fix UserReactions to render properly on top of the UserAvatar * add @debt comments to Map / Audience related code for future cleanup * add @debt comments to explain commented chunks of code * fix typo * move shoutBounceTime to SCSS variable/CSS property + pass through using useCss * align reaction timeouts in CSS * refactor $seat-size, $seat-size-min, $reactionSize into scss/constants * rename $seat-size / $seat-size-min -> $avatarSize / $avatarSizeMin + use in UserProfilePicture.scss * add @debt comment * refactor Audience component's iframeUrl handling to remove unnecessary firebase snapshot subscription * remove unused useReactionsLegacy
* Restyle search results in nav dropdown * Document and refactor some of utils/time functions; Use formatRelative * Use general scrollbar mixin * Use general transition function * Distinguish container and input classNames in the InputField * Debounce search query * Import icon directly in .tsx and copy file form public/assets to src/assets * Remove unused UserSearchBar component
* add admin venues cards to the admin v2 page * add loading page to admin v2 * handle empty venues * align admin v2 ui to match the new admin v3 * refactor * clean up after conflict resolve * fix admin cards ui * partial comment fixing * refactor and comment fixing * comment fixing and refactoring * minor tweaks and fixes * remove wrong type from venuedetails * add media breakpoints to constants.scss
* Remove duplicated styles from NavBar * Make nav dropdown appear under the navbar
…ook (#1155) * add generic twilio VideoParticipant component + useParticipantState hook * ensure isTruthyFilter correctly narrows T to exclude falsey types * add utils/twilio Co-authored-by: mike-lvov <63194656+mike-lvov@users.noreply.github.com>
github-actions
bot
added
the
💎 styles
|
@mike-lvov @sparkletown/engineering Are we confident in deploying these changes? If so, let's get this merged + pushed to all of our production environment branches. |
I tested Search Navigation one more time in the staging env. Looks like it works. So confirming my changes. |
|
@sunny-viktoryia confirmed here changes above in #1355 (comment) The twilio video refactor PR is all new code, and not referenced anywhere currently anyway, so that should be fine to ship. The refactor to the Basic click around on the Admin v2/v3 alignment changes seems ok. Based on the above + not hearing any other reasons from @sparkletown/engineering to the contrary, i'm going to merge this/get it deployed across our environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploys: