use remarkable instead of remarked for previewing to prevent XSS content #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input string contains html content, 'marked' would simply render them as actual html entities, thus bring wired previewing effect. For example, when we input strings like
<textarea>123</textarea>
, preview would show an actual textarea input, script tag will also be rendered as well. If the content is user generated, it's likely to make the users feel that there could be a XSS vulnerability.Should we change it with 'remarkable' with
html
option set tofalse
to avoid this?