Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file permission for pubKey Auth #71

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

maddingo
Copy link
Contributor

@maddingo maddingo commented Jan 26, 2024

fix permissions on authorized_keys, exclude some old versions for pubkey auth, due to missing support for encryption alg
This should fix #70

All unit tests with pubkey Auth fail on my machine, strange that the build on github succeeds

May it is easier to remove support for the older image versions

…key auth, due to missing support for encryption alg
@sparsick sparsick added the bug Something isn't working label Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (38d703a) 89.67% compared to head (f8fd99a) 88.81%.

Files Patch % Lines
...containers/gitserver/plain/GitServerContainer.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
- Coverage     89.67%   88.81%   -0.86%     
- Complexity       48       49       +1     
============================================
  Files             7        7              
  Lines           155      161       +6     
  Branches          7        7              
============================================
+ Hits            139      143       +4     
- Misses           15       17       +2     
  Partials          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparsick sparsick self-requested a review January 27, 2024 07:55
@sparsick sparsick changed the title fix pubkey auth Fix file permission for pubKey Auth Jan 27, 2024
@sparsick sparsick merged commit 1906867 into sparsick:main Jan 27, 2024
3 of 4 checks passed
@sparsick
Copy link
Owner

Thanks for the fix. I will release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh auth failed due to wrong permission of authorized_keys
2 participants