-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add itk_image_to_multiscale
method
#46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbirdso absolutely awesome!! 💯 🥇
One item -- can we please continue to use the xarray/matplotlib methods in the notebook example to demonstrate best practices and the value of MultiscaleSpatialImage. This display:
- Accounts for anisotropic spacing correctly in the spatial metadata
- Displays the correct values along the axis in physical space
- Displays the anatomical orientation
For an interactive, 3D view of the data, we will soon have itkwidgets, which will also display this information :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see notes about the notebook
Adds helper method for directly converting an `itk.Image` object to a `MultiscaleSpatialImage`. Includes 2D and 3D tests and updates ITK conversion example. Includes workaround for `itk.xarray_from_image` reference counting issue resolved in [https://github.com/InsightSoftwareConsortium/ITK/pull/3438](https://github.com/InsightSoftwareConsortium/ITK/pull/3438) to be included in itk>v5.3rc04 packages.
@thewtex Sure thing, I have reverted the notebook to rely on xarray/matplotlib visuals |
@tbirdso thanks! |
Adds helper method for directly converting an
itk.Image
object to aMultiscaleSpatialImage
. Includes 2D and 3D tests and updates ITKconversion example.
Includes workaround for
itk.xarray_from_image
reference counting issueresolved in
InsightSoftwareConsortium/ITK#3438 to be included in itk>v5.3rc04 packages.
Resolves #44.