ENH: Add itk_image_to_multiscale method
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
previously approved these changes
May 18, 2022
There was a problem hiding this comment.
@tbirdso absolutely awesome!! 💯 🥇
One item -- can we please continue to use the xarray/matplotlib methods in the notebook example to demonstrate best practices and the value of MultiscaleSpatialImage. This display:
- Accounts for anisotropic spacing correctly in the spatial metadata
- Displays the correct values along the axis in physical space
- Displays the anatomical orientation
For an interactive, 3D view of the data, we will soon have itkwidgets, which will also display this information :-)
thewtex
requested changes
May 18, 2022
Adds helper method for directly converting an `itk.Image` object to a `MultiscaleSpatialImage`. Includes 2D and 3D tests and updates ITK conversion example. Includes workaround for `itk.xarray_from_image` reference counting issue resolved in [https://github.com/InsightSoftwareConsortium/ITK/pull/3438](https://github.com/InsightSoftwareConsortium/ITK/pull/3438) to be included in itk>v5.3rc04 packages.
|
@thewtex Sure thing, I have reverted the notebook to rely on xarray/matplotlib visuals |
|
@tbirdso thanks! |
thewtex
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds helper method for directly converting an
itk.Imageobject to aMultiscaleSpatialImage. Includes 2D and 3D tests and updates ITKconversion example.
Includes workaround for
itk.xarray_from_imagereference counting issueresolved in
InsightSoftwareConsortium/ITK#3438 to be included in itk>v5.3rc04 packages.
Resolves #44.