This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
Worker connector updates & refactoring #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
jamiebrynes7
force-pushed
the
chore/worker-connector-updates
branch
from
dc312a3
to
15dd524
Compare
zeroZshadow
approved these changes
May 19, 2020
workers/unity/Assets/Fps/Scripts/WorkerConnectors/SimulatedPlayerCoordinatorWorkerConnector.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| protected int GetWorldSize() | ||
| protected async Task WaitForWorkerFlags(CancellationToken token, params string[] flagKeys) |
There was a problem hiding this comment.
This looks like it is worth integrating into the core later?
There was a problem hiding this comment.
Its worth a shout, or even a:
public Task<string> GetWorkerFlagAsync(string key, CancellationToken token);Then you can compose them:
var flags = await Task.WhenAll(Worker.GetWorkerFlagAsync("first", token), Worker.GetWorkerFlagAsync("second", token)); // Returns ["first_value", "second_value"]
|
Random through, does the map generator still work in the editor with this? Not when playing. |
Yup - just tested with a map w/ 200 tile layers, Editor pauses for a few seconds and then completes fine |
jamiebrynes7
force-pushed
the
chore/worker-connector-updates
branch
from
3e8f37c
to
fc09b7b
Compare
paulbalaji
approved these changes
May 21, 2020
|
Everything looked good on the quick playtest! 📈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
WorkerConnectorimplementations with these spatialos/gdk-for-unity#1365 changes. Additionally made all the map building useTaskrather than coroutines and did some refactoring.Tests
Documentation