Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add SpatialOSEntity.TryGetComponent #1049

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Conversation

jamiebrynes7
Copy link
Contributor

Description

Upstreamed from dog-fooding project. This helps cut down on boilerplate in IEntityGameObjectCreator implementations.

Also did a driveby refactor of GameObjectCreatorFromMetadata.

Tests

Playground tests.

Documentation

Changelog + upgrade guide!

@jamiebrynes7 jamiebrynes7 added the T: enhancement Type: This is an improvement to an existing feature label Jul 19, 2019
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: game-object-creation Area: Gameobject creation feature module size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Jul 19, 2019
@jamiebrynes7 jamiebrynes7 merged commit 8403a6f into develop Jul 19, 2019
@jamiebrynes7 jamiebrynes7 deleted the feature/nice-little-sugar branch July 19, 2019 10:40
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: game-object-creation Area: Gameobject creation feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files. T: enhancement Type: This is an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants