Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add CommandLineConnectionFlowInitializer Tests #1096

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Aug 6, 2019

Description

  • Added unit tests for CommandLineConnectionFlowInitializer.
  • While writing the tests, I noticed some semantic errors, which I fixed in CommandLineConnectionFlowInitializer.

Tests

Also yes.

Documentation

  • Changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: core Area: Core GDK size/L Denotes a PR that changes 150-299 lines, ignoring generated files. labels Aug 6, 2019
@jamiebrynes7 jamiebrynes7 force-pushed the feature/commandlineinitializer-tests branch from 96bc27c to fc26d13 Compare August 8, 2019 10:35
@jamiebrynes7 jamiebrynes7 marked this pull request as ready for review August 8, 2019 10:36
@jamiebrynes7 jamiebrynes7 merged commit 67682e0 into develop Aug 8, 2019
@jamiebrynes7 jamiebrynes7 deleted the feature/commandlineinitializer-tests branch August 8, 2019 10:43
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
* Added support for path as engine association

* Added changelog

* Cleanup

* Update RequireSetup

* Update comments

* Cleanup

* Typo

* Update gitignore

* Change to commited package

* Feedback

* Removed xml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants