This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Feature/custom snapshot launch #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows user to set a custom snapshot for local launch. The snapshot can be selected at the GDK tools configuration window
improbable-prow-robot
added
jira/no-ticket
zeroZshadow
suggested changes
Aug 7, 2019
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfiguration.cs
Outdated
Show resolved
Hide resolved
Removed custom snapshot path from GdkToolsConfiguration class / Single local launch button that will load the selected snapshot
zeroZshadow
suggested changes
Aug 7, 2019
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfiguration.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
Added customSnapshotPath PlayerPref abstraction to the GdkToolsConfiguration class / When opening the snapshot selection window it now opens on the currently selected snapshot file folder.
jamiebrynes7
suggested changes
Aug 7, 2019
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
…rationWindow.cs Co-Authored-By: Jamie Brynes <jamiebrynes@improbable.io>
Co-Authored-By: Jamie Brynes <jamiebrynes@improbable.io>
Co-Authored-By: Jamie Brynes <jamiebrynes@improbable.io>
…patialos/gdk-for-unity into feature/custom_snapshot_launch
|
Need to resolve the |
…patialos/gdk-for-unity into feature/custom_snapshot_launch
Co-Authored-By: Paul Balaji <paulbalaji@improbable.io>
jamiebrynes7
approved these changes
Aug 9, 2019
zeroZshadow
reviewed
Aug 13, 2019
zeroZshadow
reviewed
Aug 13, 2019
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationWindow.cs
Outdated
Show resolved
Hide resolved
Removed unused directive and extra newline
zeroZshadow
approved these changes
Aug 14, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Expose rep limit and consider list * Added command to process command on server * Expose multiple settings * formatting * PR feedback * Spelling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
public string CustomSnapshotPathvariable to theGdkToolsConfigurationclass and apublic const string CustomSnapshotPathto theDefaultValuesclass.Added a "Custom snapshot path" field to the "GDK Tools Configuration" window. The field is disabled and can be only be edited via a file picker.
Added a
private static GdkToolsConfiguration gdkToolsConfigvariable to theLocalLaunchclass, used to load the custom snapshot path. I've also split some code from theLaunchLocalDeploymentmethod for code reusability.Tests
Performed manual tests only with snapshots created with the snapshot generator. If an invalid snapshot is loaded the default error from the launcher is shown in the editor.
Documentation
No documentation yet
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.