Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

AlphaLocatorFlow tests #1108

Merged
merged 3 commits into from
Aug 13, 2019
Merged

AlphaLocatorFlow tests #1108

merged 3 commits into from
Aug 13, 2019

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Aug 12, 2019

Description

Currently based on top of #1104, so lots of erroneous commits. Will rebase this once #1104 is merged.

  • Fixed a potential deadlocking issue in AlphaLocatorFlow.CreateAsync().
  • Added tests for the various stages of the dev auth flow and connecting.

Tests

Yes we have tests.

Documentation

  • Changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: core Area: Core GDK size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Aug 12, 2019
@jamiebrynes7 jamiebrynes7 marked this pull request as ready for review August 13, 2019 10:24
@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Aug 13, 2019
@jamiebrynes7 jamiebrynes7 merged commit 0674de4 into develop Aug 13, 2019
@jamiebrynes7 jamiebrynes7 deleted the feature/alpha-locator-tests branch August 13, 2019 10:42
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
* Try local set

* Set local and global clang toolchain
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants