This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
label
Sep 9, 2019
improbable-prow-robot
added
A: build-system
Area: Build system feature module
A: core
Area: Core GDK
labels
Sep 9, 2019
improbable-prow-robot
added
size/XL
Denotes a PR that changes 300-599 lines, ignoring generated files.
A: maintenance
Area: Project maintenance or hygiene
A: tooling
Area: Tooling
labels
Sep 9, 2019
Optimization Results
This brought down the time from ~5000ms to ~3000ms after the first run. Of those |
jamiebrynes7
force-pushed
the
feature/modular-codegen
branch
from
September 9, 2019 13:32
d318da3
to
89009a7
Compare
get rid of async only rebuild on force
jamiebrynes7
force-pushed
the
feature/modular-codegen
branch
from
September 9, 2019 14:14
89009a7
to
171aa0b
Compare
zeroZshadow
approved these changes
Sep 9, 2019
workers/unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/.template.config/template.json
Outdated
Show resolved
Hide resolved
jessicafalk
reviewed
Sep 9, 2019
jessicafalk
approved these changes
Sep 9, 2019
jamiebrynes7
force-pushed
the
feature/modular-codegen
branch
from
September 9, 2019 15:51
6f44e34
to
14982e8
Compare
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
… worker type (#1151) * Only pack RPCs that are destined for the owning worker type of the connection (PlayerController). * Add new method to ActorGroupManager for checking 2 actors are owned by the same worker type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: build-system
Area: Build system feature module
A: core
Area: Core GDK
A: maintenance
Area: Project maintenance or hygiene
A: mobile
Area: Mobile integration
A: tooling
Area: Tooling
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XL
Denotes a PR that changes 300-599 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a first pass at modular codegen which utilizes dotnet templates to assist in generating a skeleton project.
The process goes as follows:
cd $UNITY_PACKAGES_DIR/io.improbable.gdk.tools/.CodeGenTemplate/ && dotnet new -i ./
$UNITY_BUILD_SCRATCH/codegen
directory.cd $UNITY_BUILD_SCRATCH/codegen && dotnet new gdk-for-unity-codegen
.codegen
directories in packages..csproj
and link in any source, templates, and partials in each of the.codegen
directories.For this first implementation, any time a user runs codegen, all the steps above happen. This has have an impact on performance of operation:
What particularly hurts is we lose all build artifact caching built into
dotnet/msbuild
since we wipe thecodegen
directory every time. For future optimizations, we should focus on only doing this when necessary.Possible optimizations
codegen
directory unless the template has changed..csproj
file.All of these optimizations rely on us detecting the
template
has changed. If we can do this, we can adjust the solution above to:a. If yes, do steps 2-4 from above.
.codegen
directories in packages..csproj
and link in any source, templates, and partials in each of the.codegen
directories.This PR also contains a driveby refactor on
RedirectedProcess
such that the synchronousRun()
now returns theRedirectedProcessResult
type to make it consistent with the asynchronous one.Remaining work