Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Fix ScrollView display for all tabs #1175

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Fix ScrollView display for all tabs #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da4a223
Fix ScrollView display for all tabs when you have a large amount of c…
zeroZshadow Sep 26, 2019
b6e29b5
changelog
zeroZshadow Sep 26, 2019
e83cbb4
Driveby - Flipping Added and Breaking in changelog
zeroZshadow Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,19 @@

## Unreleased

### Added

- Added commands and world commands tabs to the Network Analyzer window. [#1174](https://github.com/spatialos/gdk-for-unity/pull/1174)

### Breaking Changes

- The `GetComponentId<T>()` and `GetSnapshotComponentId<T>()` methods have been moved from `Dynamic` to `ComponentDatabase`. [#1173](https://github.com/spatialos/gdk-for-unity/pull/1173)

### Added

- Added commands and world commands tabs to the Network Analyzer window. [#1174](https://github.com/spatialos/gdk-for-unity/pull/1174)

### Fixed

- Fixed a bug where the `TransformSynchronization` MonoBehaviour would not reset when disabled. [#1169](https://github.com/spatialos/gdk-for-unity/pull/1169)
- Fixed a bug where the `UnlinkGameObjectFromEntity` method in the `EntityGameObjectLinker` would not cleanup the `gameObjectToComponentsAdded` dictionary. [#1169](https://github.com/spatialos/gdk-for-unity/pull/1169)
- Fixed a bug where the Network Analyzer would not properly render all components/commands in the scroll view. [#1175](https://github.com/spatialos/gdk-for-unity/pull/1175)

### Internal

Expand Down
4 changes: 2 additions & 2 deletions workers/unity/Packages/io.improbable.gdk.debug/NetStatsViewer/NetStatsTab.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ public void Update()
{
var scrollView = this.Q<ScrollView>("container");
var count = scrollView.childCount;
var viewportBound = scrollView.contentViewport.localBound;
var viewportBound = scrollView.contentViewport.worldBound;

// Update all visible items in the list
for (var i = 0; i < count; i++)
{
var element = scrollView[i];
if (viewportBound.Overlaps(element.localBound))
if (viewportBound.Overlaps(element.worldBound))
{
UpdateElement(i, element);
}
Expand Down