This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Codegen line endings #1189
Merged
Codegen line endings #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
paulbalaji
reviewed
Oct 14, 2019
| // Fix up line endings | ||
| var contents = entry.Value | ||
| .Replace("\r\n", "\n") | ||
| .Replace("\n", Environment.NewLine); |
There was a problem hiding this comment.
maybe add a comment on why we don't do replacements on just \r here
and add internal changelog
There was a problem hiding this comment.
How does the release tool react to me adding to the changelog at this point?
I'm not sure why this needs a comment, \r isn't a thing.
There was a problem hiding this comment.
How does the release tool react to me adding to the changelog at this point?
It doesn't care
paulbalaji
approved these changes
Oct 15, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Use weak pointer in UnrealMetadata * Add log for stale classes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for auto-crlf issues with T4 template files.