This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Subscription cleanup #1200
Merged
Subscription cleanup #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folder rename metafiles
Named tuples
improbable-prow-robot
added
do-not-merge/work-in-progress
…GuardedCallbackManagerSet
jessicafalk
reviewed
Oct 23, 2019
.../Packages/io.improbable.gdk.core/Subscriptions/CallbackManagers/GuardedCallbackManagerSet.cs
Show resolved
Hide resolved
jessicafalk
reviewed
Oct 23, 2019
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/SubscriptionAggregate.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/Callbacks/IndexedCallbacks.cs
Outdated
Show resolved
Hide resolved
|
|
||
| namespace Improbable.Gdk.Subscriptions | ||
| { | ||
| public static class EntitySubscriptions |
There was a problem hiding this comment.
what was the initial purpose of this class?
There was a problem hiding this comment.
It has never been used.
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/Systems/SubscriptionSystem.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/Systems/ComponentCallbackSystem.cs
Outdated
Show resolved
Hide resolved
.../Packages/io.improbable.gdk.core/Subscriptions/CallbackManagers/GuardedCallbackManagerSet.cs
Show resolved
Hide resolved
improbable-prow-robot
added
size/XXL
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
| @@ -197,7 +197,7 @@ public void FlushCommandBuffer() | |||
| if (!workerSystem.TryGetEntity(entityId, out var entity)) | |||
| { | |||
| throw new ArgumentException( | |||
| $"Can not add GameObjet components to entity {entityId}. Entity not in view"); | |||
| $"Can not add GameObject components to entity {entityId}. Entity not in view"); | |||
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/Subscription.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/SubscriptionAggregate.cs
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/SubscriptionAggregate.cs
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Subscriptions/Systems/SubscriptionSystem.cs
Outdated
Show resolved
Hide resolved
jamiebrynes7
approved these changes
Oct 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In trying to debug subscription issues, and split up the package, we've found that its currently in a bit of a state.
This PR hopes to address some of this, by ensuring the code follows our overall style guide and has a clearer API
This is WIP as I'd still like to make some changes to our Callbacks code.
Please review in commit order, I've tried to keep things manageable.
Documentation