Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

[UTY-2391] CodeWriter v2: entry point for writing generators (3/3) #1240

Merged
merged 6 commits into from
Jan 16, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Jan 14, 2020

Description

  • CodeWriter class to create and use the CodeWriter
  • static Scope class to create some of the code blocks outside of a CodeWriter
    • useful when splitting up a big generator into separate methods

Documentation

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2391

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/UTY size/L Denotes a PR that changes 150-299 lines, ignoring generated files. A: tooling Area: Tooling labels Jan 14, 2020
@paulbalaji paulbalaji changed the title [UTY-2391] CodeWriter entry point for writing generators [UTY-2391] CodeWriter v2: entry point for writing generators Jan 14, 2020
@improbable-prow-robot improbable-prow-robot added size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. and removed size/L Denotes a PR that changes 150-299 lines, ignoring generated files. labels Jan 16, 2020
@paulbalaji paulbalaji changed the title [UTY-2391] CodeWriter v2: entry point for writing generators [UTY-2391] CodeWriter v2: entry point for writing generators (3/3) Jan 16, 2020
@paulbalaji paulbalaji force-pushed the feature/codewriter-v2-ns-struct-class-enum branch 2 times, most recently from 809c155 to 711e22b Compare January 16, 2020 11:52
@paulbalaji paulbalaji force-pushed the feature/codewriter-v2-generator-entrypoint branch from cb74f69 to 3219dbc Compare January 16, 2020 12:22
@paulbalaji paulbalaji changed the base branch from feature/codewriter-v2-ns-struct-class-enum to develop January 16, 2020 12:22
Paul Balaji added 5 commits January 16, 2020 12:23
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@paulbalaji paulbalaji force-pushed the feature/codewriter-v2-generator-entrypoint branch from 3219dbc to ccab2fd Compare January 16, 2020 12:23
@paulbalaji paulbalaji marked this pull request as ready for review January 16, 2020 12:27
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@paulbalaji paulbalaji merged commit 4cb620d into develop Jan 16, 2020
@paulbalaji paulbalaji deleted the feature/codewriter-v2-generator-entrypoint branch January 16, 2020 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: tooling Area: Tooling jira/UTY size/XL Denotes a PR that changes 300-599 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants