This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
[UTY-2393] Port build system module to new CodeWriter #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2020 14:27
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2392 |
improbable-prow-robot
added
jira/UTY
A: build-system
paulbalaji
changed the title
jamiebrynes7
approved these changes
Jan 16, 2020
...ect/Assets/Generated/Source/improbable/testschema/ExhaustiveSingularComponentReaderWriter.cs
Outdated
Show resolved
Hide resolved
Comment on lines
73
to
81
| buildWorkerMenu.Method("private static void MenuBuildLocal(string[] filteredWorkerTypes)", m => | ||
| { | ||
| m.Line("WorkerBuilder.MenuBuild(BuildEnvironment.Local, filteredWorkerTypes);"); | ||
| }); | ||
|
|
||
| buildWorkerMenu.Method("private static void MenuBuildCloud(string[] filteredWorkerTypes)", m => | ||
| { | ||
| m.Line("WorkerBuilder.MenuBuild(BuildEnvironment.Cloud, filteredWorkerTypes);"); | ||
| }); |
There was a problem hiding this comment.
Reading through this again - these seem mostly redundant
There was a problem hiding this comment.
yeah - could just call WorkerBuild.MenuBuild directly
zeroZshadow
reviewed
Jan 16, 2020
...mprobable.gdk.buildsystem/.codegen/Source/Generators/BuildSystem/UnityWorkerMenuGenerator.cs
Outdated
Show resolved
Hide resolved
...mprobable.gdk.buildsystem/.codegen/Source/Generators/BuildSystem/UnityWorkerMenuGenerator.cs
Outdated
Show resolved
Hide resolved
jessicafalk
approved these changes
Jan 16, 2020
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
zeroZshadow
approved these changes
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port build system module to new CodeWriter
Tests
check generated code diff
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.