Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

[WRK-1840] Change Worker SDK packages used for iOS #1268

Merged
merged 8 commits into from
Feb 5, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Feb 4, 2020

Description

Workaround for WRK-1840.

  • Changed iOS worker sdk packages
    • c-static-arm-clang-ios (previously c-static-fullylinked-arm-clang-ios)
    • c-static-x86_64-clang-ios (previously c-static-fullylinked-x86_64-clang-ios)
  • Updated meta files
  • Tested on iPhone and Simulator
  • Drive-by tweak to iOSLaunchUtils
    • log the stderr from trying to run simulator / trying to build xcode project

Tests

  • XCode project builds for iPhone
  • XCode project builds for Simulator
  • iPhone connects to cloud deployment
  • Simulator connects to cloud deployment

Documentation

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/WRK-1840

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/WRK Indicates a PR has a corresponding JIRA WRK ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Feb 4, 2020
@improbable-prow-robot improbable-prow-robot added the A: mobile Area: Mobile integration label Feb 4, 2020
@paulbalaji paulbalaji marked this pull request as ready for review February 4, 2020 18:24
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2020
@zeroZshadow zeroZshadow mentioned this pull request Feb 5, 2020
@paulbalaji paulbalaji merged commit 89555f8 into develop Feb 5, 2020
@paulbalaji paulbalaji deleted the bugfix/ios-wsdk branch February 5, 2020 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: mobile Area: Mobile integration jira/WRK Indicates a PR has a corresponding JIRA WRK ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants