Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

PlayerLifecycle integration with the EntityReservationSystem #1315

Merged
merged 5 commits into from
Mar 13, 2020
Merged

PlayerLifecycle integration with the EntityReservationSystem #1315

merged 5 commits into from
Mar 13, 2020

Conversation

zeroZshadow
Copy link
Contributor

@zeroZshadow zeroZshadow commented Mar 12, 2020 •
edited
Loading

Description

Player spawning now uses the EntityReservationSystem to provide a known entityId.
This is added to the CreatePlayerEntityTemplate for use in QBI.

This is a breaking change.

Tests

Playground tested.

Documentation

  • Changelog
  • Upgrade Guide

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Mar 12, 2020
@improbable-prow-robot improbable-prow-robot added A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground labels Mar 12, 2020
paulbalaji
paulbalaji reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, few questions about changelog/upgrade guide

CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
jamiebrynes7
jamiebrynes7 reviewed Mar 12, 2020
View reviewed changes
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.gdk.playerlifecycle/PlayerLifecycleHelper.cs Show resolved Hide resolved
austinkelmore
austinkelmore reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@austinkelmore austinkelmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me from what I can tell, I agree with the suggested changes on the docs.

This was referenced Mar 12, 2020
Merged
Merged
@zeroZshadow zeroZshadow merged commit 9d0b4c8 into develop Mar 13, 2020
@zeroZshadow zeroZshadow deleted the feature/playerlifecycle-reserved-id branch March 13, 2020 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinkelmore austinkelmore austinkelmore left review comments

@paulbalaji paulbalaji paulbalaji approved these changes

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeroZshadow @austinkelmore @paulbalaji @jamiebrynes7 @improbable-prow-robot