Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Unity 2019.3.7f1 upgrade #1336

Merged
merged 19 commits into from
Mar 30, 2020
Merged

Unity 2019.3.7f1 upgrade #1336

merged 19 commits into from
Mar 30, 2020

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Mar 27, 2020 •
edited
Loading

Description

A follow on from #1272, this PR updates the GDK to 2019.3. Again, most of these changes are asset re-imports, sorry 'bout it.

Tests

  • Release QA pipeline
  • iOS client
  • MacOS client
  • Windows client

Documentation

  • Changelog
  • Upgrade guide
  • Docs update

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: build-system Area: Build system feature module size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: mobile Area: Mobile integration A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module labels Mar 27, 2020
paulbalaji
paulbalaji approved these changes Mar 27, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Update CHANGELOG.md
822d017 
Co-Authored-By: Paul Balaji <paulbalaji@improbable.io>
jamiebrynes7
jamiebrynes7 commented Mar 27, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jamiebrynes7
Copy link
Contributor Author

👋 @MarkWoulfeImprobable, @anne-edwards, @ElleEss - I've added you to this PR since we are going to have tech writer approval on changelogs from now on.

You can find the changelog change here https://github.com/spatialos/gdk-for-unity/pull/1336/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR7 :)

@jamiebrynes7
Copy link
Contributor Author

Also @SPPWilliams ☝️ now that you have access!

@jamiebrynes7 jamiebrynes7 mentioned this pull request Mar 30, 2020
Merged
anne-edwards
anne-edwards approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@anne-edwards anne-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tiny things

CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
@anne-edwards
Update changelog + upgrade guide
51bd8d3 
Co-Authored-By: anne-edwards <32169118+anne-edwards@users.noreply.github.com>
@jamiebrynes7 jamiebrynes7 merged commit 79dc4b1 into develop Mar 30, 2020
@zeroZshadow zeroZshadow deleted the feature/unity-2019.3 branch April 7, 2020 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@anne-edwards anne-edwards anne-edwards approved these changes

@austinkelmore austinkelmore Awaiting requested review from austinkelmore

@ElleEss ElleEss Awaiting requested review from ElleEss

@MarkWoulfeImprobable MarkWoulfeImprobable Awaiting requested review from MarkWoulfeImprobable

@SPPWilliams SPPWilliams Awaiting requested review from SPPWilliams

Assignees
No one assigned
Labels
A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: mobile Area: Mobile integration A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamiebrynes7 @zeroZshadow @paulbalaji @anne-edwards @improbable-prow-robot