This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Add worker details to worker inspector #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
jamiebrynes7
force-pushed
the
feature/worker-inspector-worker-info
branch
from
a2a8d38
to
2e8f4fc
Compare
jamiebrynes7
force-pushed
the
feature/worker-inspector-worker-info
branch
from
9372838
to
f8774f1
Compare
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
zeroZshadow
approved these changes
Jun 4, 2020
| container.AddToClassList("flag-element-container"); | ||
|
|
||
| var key = new Label { name = FlagKeyName, }; | ||
|
|
There was a problem hiding this comment.
Why all the whitespace here?
There was a problem hiding this comment.
The initializer was spanning multiple lines, but then I linted and it collapsed it. 🤷♂️
paulbalaji
approved these changes
Jun 4, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small section for general worker information:
Sadly Unity doesn't have
inline-flexas an option, so we can't have the worker flags section expand up to a given size with flex. For expediency's sake, this is just set to a fixed height percentage. The worker flags section will have a scrollbar if the contents are too large.Unity also doesn't have the ability to define what happens for text overflows in an element, so very very long worker flags can overflow the container.
Tests
Ran it on a local deployment w/ some worker flags, and some without. Swapping worlds, etc.
Documentation