Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add rendering support for user-defined types #1391

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

jamiebrynes7
Copy link
Contributor

Description

This PR adds support for rendering user-defined schema types in the Worker Inspector.

  • We generate a VisualElement implementation for each schema type.
  • This is then used in components and other types to opaquely render the schema type.

Each type has indented labels (which does then indent the field, we can look at resolving this later, but its non-trivial).

This PR also fixed some of the styling issues (where the fields were entirely grayed out due to an opacity setting).

image

Tests

Eyeball test with nested types.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: tooling Area: Tooling size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. labels Jun 10, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jamiebrynes7 jamiebrynes7 merged commit d60046b into develop Jun 11, 2020
@improbable-prow-robot improbable-prow-robot deleted the feature/worker-inspector-user-defined-types branch June 11, 2020 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XL Denotes a PR that changes 300-599 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants