Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

[UTY-2631] Add new menu item to open inspector v2 #1407

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

seanjparker
Copy link
Contributor

@seanjparker seanjparker commented Jun 25, 2020

Description

  • Added a new menu item to the SpatialOS menu that opens inspector v2
  • Update android SDK versions in init.ps1 script to match those in init.sh

Tests

How did you test these changes prior to submitting this pull request?
Manually tested that inspector v2 opens in browser

What automated tests are included in this PR?
None

Documentation

How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Added to changelog

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2631

@improbable-prow-robot improbable-prow-robot added jira/UTY A: tooling Area: Tooling size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jun 25, 2020
Copy link
Contributor

@austinkelmore austinkelmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :)

@improbable-prow-robot improbable-prow-robot added size/S Denotes a PR that changes 15-39 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jun 25, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@seanjparker seanjparker merged commit bce8a43 into develop Jun 25, 2020
@improbable-prow-robot improbable-prow-robot deleted the inspector-v2-menu-item branch June 25, 2020 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: tooling Area: Tooling jira/UTY size/S Denotes a PR that changes 15-39 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants