Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Limit perftest targets + package dependency fix #1416

Merged
merged 6 commits into from
Jul 6, 2020
Merged

Limit perftest targets + package dependency fix #1416

merged 6 commits into from
Jul 6, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Jul 6, 2020 •
edited
Loading

Description

This should also reduce our machine usage on premerge builds significantly

  • Configure branch filters for the various perf testing targets:
    • only .net 2.0/burst enabled/Mono target is allowed for playmode/editmode on pre-merge
    • all targets run on master/develop
  • Moved test framework/perftest package dependency to testutils instead of playground manifest
  • only run the csproj/sln initialization if there are any matching targets

Tests

  • Ran locally, only subset ran
  • Run in buildkite, only subset should run
  • Ran with branch variable set to master/develop, it iterates through all expected targets

Documentation

  • internal changelog about adding dependencies to testutils package

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Jul 6, 2020
@improbable-prow-robot improbable-prow-robot added the A: maintenance Area: Project maintenance or hygiene label Jul 6, 2020
Paul Balaji added 4 commits July 6, 2020 12:47
skip perftest job if no targets for current branch
2c2e7f1 
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
changelog
51cebb9 
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
woops
d5e6a10 
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
set branch name in variable at start
0913ae2 
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@paulbalaji paulbalaji marked this pull request as ready for review July 6, 2020 12:31
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulbalaji paulbalaji merged commit f2a418f into develop Jul 6, 2020
@improbable-prow-robot improbable-prow-robot deleted the fix/perftest branch July 6, 2020 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@seanjparker seanjparker seanjparker approved these changes

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@austinkelmore austinkelmore Awaiting requested review from austinkelmore

@BryanJY-Wong BryanJY-Wong Awaiting requested review from BryanJY-Wong

Assignees
No one assigned
Labels
A: maintenance Area: Project maintenance or hygiene jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulbalaji @zeroZshadow @seanjparker @jamiebrynes7 @improbable-prow-robot