Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

UTY-2643: fix codegen indentation #1424

Merged
merged 3 commits into from
Jul 13, 2020
Merged

UTY-2643: fix codegen indentation #1424

merged 3 commits into from
Jul 13, 2020

Conversation

BryanJY-Wong
Copy link
Contributor

@BryanJY-Wong BryanJY-Wong commented Jul 13, 2020 •
edited
Loading

Description

Standardizes newlines before replacing

Tests

Ran codegen with the changes in fps-starter-project where bug was observed

Documentation

None

  • Did you remember a changelog entry?

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@BryanJY-Wong BryanJY-Wong self-assigned this Jul 13, 2020
@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2643

@improbable-prow-robot improbable-prow-robot added A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: maintenance Area: Project maintenance or hygiene A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground A: tooling Area: Tooling labels Jul 13, 2020
@BryanJY-Wong BryanJY-Wong changed the base branch from master to develop July 13, 2020 13:08
@improbable-prow-robot improbable-prow-robot added size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jul 13, 2020
jamiebrynes7
jamiebrynes7 approved these changes Jul 13, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@BryanJY-Wong
Update CHANGELOG.md
f229f6e 
Co-authored-by: Jamie Brynes <jamiebrynes@improbable.io>
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BryanJY-Wong BryanJY-Wong merged commit 21a318e into develop Jul 13, 2020
@improbable-prow-robot improbable-prow-robot deleted the bug/fix-codegen-identation branch July 13, 2020 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@zeroZshadow zeroZshadow Awaiting requested review from zeroZshadow

Assignees

@BryanJY-Wong BryanJY-Wong

Labels
A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: maintenance Area: Project maintenance or hygiene A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground A: tooling Area: Tooling jira/UTY size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BryanJY-Wong @improbable-prow-robot @paulbalaji @jamiebrynes7