This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Support multiple annotations on method/type/enum blocks in Code Writer API #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanjparker
requested review from
zeroZshadow,
paulbalaji,
jamiebrynes7 and
BryanJY-Wong
improbable-prow-robot
added
jira/no-ticket
...obable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBlock.cs
Outdated
Show resolved
Hide resolved
...nity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scope.cs
Outdated
Show resolved
Hide resolved
paulbalaji
approved these changes
Jul 16, 2020
| @@ -7,17 +7,17 @@ namespace CodeGenerationLib.CodeWriter.Scopes | |||
| public class AnnotationOutsideType | |||
| { | |||
| protected readonly ScopeBlock ParentBlock; | |||
| protected readonly string Annotation; | |||
| protected readonly List<string> Annotations; | |||
There was a problem hiding this comment.
Missed this nevermind
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UTY-2658
Description
Added support for adding multiple annotations in the Code Writer API on method/type/enum code blocks that use a
ScopeBlockTests
How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Added Changelog entry