Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Fix the PrefabPreprocessor #1438

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Jul 24, 2020

Description

We broke this in by #1393 as we forgot to change the string when we re-named it. I've changed it to a typeof() to avoid this in the future.

Tests

  • Removed a behaviour and re-added it. Hit play and checked the prefab to make sure it was disabled.

Documentation

  • Changelog

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2679

@improbable-prow-robot improbable-prow-robot added A: core Area: Core GDK size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jul 24, 2020
@jamiebrynes7 jamiebrynes7 requested review from seanjparker, austinkelmore and BryanJY-Wong and removed request for zeroZshadow July 24, 2020 11:09
@@ -44,7 +44,7 @@ private static void OnPlaymodeStateChanged(PlayModeStateChange playModeStateChan

private static void PreprocessPrefabs()
{
var resolvers = AssetDatabase.FindAssets("t:EntityLinkerDatabase")
var resolvers = AssetDatabase.FindAssets($"t:{typeof(EntityRepresentationMapping)}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jamiebrynes7 jamiebrynes7 merged commit 85fcb49 into develop Jul 24, 2020
@improbable-prow-robot improbable-prow-robot deleted the bugfix/UTY-2679-prefab-preprocessor branch July 24, 2020 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/UTY size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants