Explicitly mark $primaryKeyColumn and $modifyQuery parameters as …

…nullable
spatie · Dec 21, 2024 · ccef4c2 · ccef4c2
1 parent d6a6dc9
commit ccef4c2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/SortableTrait.php b/src/SortableTrait.php
@@ -44,8 +44,8 @@ public function scopeOrdered(Builder $query, string $direction = 'asc')
     public static function setNewOrder(
         $ids,
         int $startOrder = 1,
-        string $primaryKeyColumn = null,
-        callable $modifyQuery = null
+        ?string $primaryKeyColumn = null,
+        ?callable $modifyQuery = null
     ): void {
         if (! is_array($ids) && ! $ids instanceof ArrayAccess) {
             throw new InvalidArgumentException('You must pass an array or ArrayAccess object to setNewOrder');