Catch TypeError in tryFrom #105

bluemmb · 2021-08-01T11:09:46Z

I'm not sure if this is not put intentionally or it's a bug.

But using tryFrom gives the programmer safety feel to call it especially with null values until you get an exception, read the code and realize you need to add extra try or condition into your code.

I'm not sure if this is not put intentionally or it's a bug. But using `tryFrom` gives the programmer safety feel to call it especially with `null` values until you get an exception, read the code and realize you need to add extra try or condition into your code.

Gummibeer · 2021-08-01T14:47:40Z

Hey,
thanks for the PR. As the goal of that method is to be pre-8.1 polyfill I will have to check how the native one will behave.
I wasn't sure if Status::tryFrom([]) will be catched!? 🤔
As an array or object are just impossible value types.
So could be that we would have to add some more checks. But I will check and let you know.
Just the reason why we don't catch Throwable.

Gummibeer · 2021-08-04T06:26:07Z

So I've tried PHP8.1 enum tryFrom() with different types - all types are allowed except of array and object.
So this should be the goal for the current method too. I would happily welcome a PR fixing this and adding a test for all cases. Otherwise I will do it when I have time.

https://laravelplayground.com/#/?php=81