Add isset() support for label and value #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gummibeer
approved these changes
Oct 21, 2021
|
Thanks, you are totally right with both points.^^ |
Gummibeer
added
hacktoberfest
|
Any update on this? 🙂 |
|
Hey, thanks for your contribution and sorry for the massive delay! 🙏 In case you want to check why it took so long: |
|
@Gummibeer No worries, thanks for the release and good luck with everything :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As both
labelandvalueproperties can currently be accessed through the magic getter, isset will return false if you try to check for them.This PR adds a simple __isset() method that returns true for
labelandvalueproperties. I feel like this is probably not used much and thus not noticed so far, but having isset working would be expected behavior for me.