Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to return a closure to map values and labels #87

Merged
merged 2 commits into from
Jan 13, 2021
Merged

allow to return a closure to map values and labels #87

merged 2 commits into from
Jan 13, 2021

Conversation

Gummibeer
Copy link
Collaborator

replaces #83
fixes #83

@Gummibeer Gummibeer added the enhancement New feature or request label Dec 26, 2020
@Gummibeer Gummibeer self-assigned this Dec 26, 2020
@Gummibeer Gummibeer mentioned this pull request Dec 26, 2020
Closed
@Gummibeer
Copy link
Collaborator Author

@brendt could you review the changes.
They shouldn't be breaking as I've dropped a native return type-hint but it's still compatible as I've only added a new possible return type.
Or should we switch to PHP ^8.0 only here and use native return type-hints for the new union types?
In my opinion, if it's wanted to drop PHP7.4, I would favor a 7.4 compatible release of this feature and afterward drop 7.4 and update the type-hints everywhere.

@brendt
Copy link
Collaborator

brendt commented Jan 13, 2021

Hi Tom, looks great as well. I'd keep PHP 7.4 support for a little while longer. Feel free to merge, looks perfect!

@brendt
Copy link
Collaborator

brendt commented Jan 13, 2021

Oh one more thing: we should also update the docs once this is merged.

@Gummibeer
Copy link
Collaborator Author

Sure, will always update the docs as soon as the feature is final/merged. 😉

@Gummibeer Gummibeer merged commit 1a57375 into master Jan 13, 2021
@Gummibeer Gummibeer deleted the closure-based-maps branch January 13, 2021 11:49
@Gummibeer
Copy link
Collaborator Author

https://github.com/spatie/enum/releases/tag/3.7.0

@sebastiandedeyne sebastiandedeyne mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendt brendt brendt approved these changes

@ahmedsayedabdelsalam ahmedsayedabdelsalam ahmedsayedabdelsalam approved these changes

Assignees

@Gummibeer Gummibeer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gummibeer @brendt @ahmedsayedabdelsalam