Cast value to string for createFromFormat

[kylekatarnls]

Cast $value to string explictly because DateTime::createFromFormat() expects string since PHP 8

Fix #708

[kylekatarnls]

Hello 👋

I know it's not spatie/laravel-data responsibility to explicit this cast since since you don't use declare(strict_types=1) in this file and the cast happens implictly. But I have some tricky constraints with Carbon upgrade from 2 to 3. And it fails trying to do:

Carbon::createFromFormat('U', $timestamp)

With $timestamp is int.

[Elnadrion]

Is this PR going to be merged any soon? My team has exact same problem after bumping laravel-data, carbon and laravel to the next major versions

[kylekatarnls]

@rubenvanassche 🙏 I'm sorry this strict type change affect your library. I will evaluate if I can do smarter validation such as accepting and casting int if the format is a single letter that expect a numeric value.

But meanwhile a cast would be the safer fix.

[Elnadrion]

@kylekatarnls as a temp solution for the issue we created custom caster:

<?php

namespace App\Casters;

use DateTimeInterface;
use Spatie\LaravelData\Casts\DateTimeInterfaceCast;
use Spatie\LaravelData\Casts\Uncastable;
use Spatie\LaravelData\Support\Creation\CreationContext;
use Spatie\LaravelData\Support\DataProperty;

class CustomDateTimeInterfaceCast extends DateTimeInterfaceCast
{
    public function cast(DataProperty $property, mixed $value, array $properties, CreationContext $context): DateTimeInterface|Uncastable
    {
        return parent::cast($property, (string)$value, $properties, $context);
    }

    public function castIterableItem(DataProperty $property, mixed $value, array $properties, CreationContext $context): DateTimeInterface|Uncastable
    {
        return parent::castIterableItem($property, (string)$value, $properties, $context);
    }
}

[rubenvanassche]

Thanks!