-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect data from collection #812
Detect data from collection #812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool PR!
Two remarks about caching + could you also add a more integration like test in DataTest
where you create a data object with such a special DataCollection property? Then we know for sure everything is working.
Thanks!
@rubenvanassche Thank you for your remarks. I have created an integration test and added some caching. PS: I noticed a new error with PHPStan, but I don't think it's linked to this PR:
|
Thanks! |
This PR introduces a new feature that allows the use of well-annotated collections without the need for annotations inside the
Data
class. By ensuring that collections are well-annotated, we can achieve strong typing and better static analysis, eliminating the need to redundantly annotate properties in classes that utilize these collections.For example: