Added an extra rejection to prevent events being passed to invalid handlers #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiandedeyne
requested changes
Sep 4, 2023
sebastiandedeyne
requested changes
Sep 4, 2023
|
I can't think of a reason someone would have deliberately created a real event handler that could accept null as its first argument, or even done that accidentally.... |
|
The only case I can think of is a "catch-all" projector or reactor without a typehint, but in that case it can be fixed by hinting Merging and tagging, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437. Essentially if you'll accept null you're too accepting (un-typed params, variadics etc.) I also added a test to check handling interfaces still works.