Use Lazy Collection for artisan commands #3670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #3669...
The artisan commands are the only place that the
getBy*()
andgetOrphans*()
methods are used within the package.As
MediaRepository
is not yet configurable the only impacted users for this change would be those that replace it in the container, or those that resolve it and expect Eloquent Collections from thegetBy*()
andgetOrphans*()
methods.Alternatively, we could introduce an interface to bind to and a
repository_class
configuration option, and ship aCursorMediaRepository
that returnsLazyCollections
from thegetBy*()
andgetOrphans*()
methods. I initially started down this path however, I can't think of a reason that the artisan commands shouldn't always useLazyCollection
.If it's decided that the latter option is better, we should take the opportunity of a major release to create a
MediaCollections\MediaRepositories
namespace.I'm open to feedback.