Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyServiceProviderInApp doesn't work in Laravel 11 #128

Closed
lanz1 opened this issue Mar 18, 2024 · 0 comments
Closed

copyServiceProviderInApp doesn't work in Laravel 11 #128

lanz1 opened this issue Mar 18, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lanz1
Copy link

lanz1 commented Mar 18, 2024

The method copyServiceProviderInApp tries to register in app.php.
Doesn't work anymore in Laravel 11 (on new installations) because the providers array is in bootstrap/providers.php.

Is there a way for this package to detect the used config and act accordingly?

Thanks for looking into this.
@freekmurze freekmurze added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 19, 2024
jetwes pushed a commit to jetwes/laravel-package-tools that referenced this issue Mar 19, 2024
fixed spatie#128 - check if l11 with new skeleton is used
c892efe 
respects old file pattern on updated l11 installations
freekmurze added a commit that referenced this issue Mar 20, 2024
@freekmurze
Merge pull request #129 from jetwes/main
f25a941 
fixed #128 - check if l11 with new skeleton is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freekmurze @lanz1