Allow command optimization #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase against main? |
Riley19280
force-pushed
the
optimize-commands
branch
from
0d25f1f to
ee9dfca
Compare
|
@freekmurze Rebased! |
freekmurze
requested changes
Dec 11, 2024
| public function hasOptimization(?string $optimize = null, ?string $clear = null, ?string $key = null): static | ||
| { | ||
| $this->optimizeCommands[] = [ | ||
| 'optimize' => $optimize, |
There was a problem hiding this comment.
This will be a command right? Rename the variable to optimizeCommand, same for clearCommand and packagenameKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel added support for integrating with the base
optimizeandoptimize:clearcommands, so this PR adds support for that functionality like so:Note that this PR depends on L11 development support for testing, so those changes are also shown