Adds setRoleClass method to PermissionRegistrar

[timschwartz]

Issue #1864

Adding this to allow configuration of Role model class from a package's service provider.

[erikn69]

You have to keep in mind that this package uses cache and preload models in memory, and if you are going to change the models in the runtime(after cache load), maybe you could have unexpected failures because models from cache will be default ones(is what I understood in #1864), maybe you could add some test to check that

[timschwartz]

Would duplicating the existing tests/RoleTest.php and modifying its setUp() to use a runtime configured model be the way to do that? I've never written a test before.

[PaolaRuby]

I think these tests are unnecessary, because they check the same as existing tests

Maybe you do not need a test because it is possible that only you need that method

[erikn69]

I don't mean duplicating the existing tests/RoleTest.php and modifying its setUp(), and those tests also have errors, did you run ./vendor/bin/phpunit?

ERRORS!
Tests: 377, Assertions: 794, Errors: 1, Failures: 1.

[erikn69]

@drbyte also maybe better

use Spatie\Permission\Contracts\Permission;
use Spatie\Permission\Contracts\Role;

    public function setPermissionClass($permissionClass)
    {
        $this->permissionClass = $permissionClass;
        config()->set('permission.models.role',  $permissionClass);
        app()->bind(Permission::class, $permissionClass); 
        return $this;
    }
    public function setRoleClass($roleClass)
    {
        $this->roleClass = $roleClass;
        config()->set('permission.models.role',  $roleClass);
        app()->bind(Role::class, $roleClass);  
        return $this;
    }

[timschwartz]

I don't mean duplicating the existing tests/RoleTest.php and modifying its setUp(), and those tests also have errors, did you run ./vendor/bin/phpunit?

ERRORS!
Tests: 377, Assertions: 794, Errors: 1, Failures: 1.

Sorry, I pushed that to my branch just to save my work, I wasn't finished yet. I will read over the rest of the replies and fix it up.

[timschwartz]

@erikn69 Do I need to make anymore modifications to this?

[erikn69]

I'm just trying to help, you have to wait for a collaborator to review the pr, they haven't connected lately

[freekmurze]

Thanks!