Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lumen Support #8

Closed
chris-doehring opened this issue Jan 7, 2021 · 2 comments
Closed

Lumen Support #8

chris-doehring opened this issue Jan 7, 2021 · 2 comments

Comments

@chris-doehring
Copy link
Collaborator

chris-doehring commented Jan 7, 2021

Hey guys,

congrats on the release of ray! It would be nice if the Laravel integration could also support Lumen. I have tried it locally and the only blockers should be the following:

  • Spatie\LaravelRay\DumpRecorder\DumpRecorder requires the Application Contract which Lumen does not support, but it could be replaced by Illuminate\Container\Container instead
  • The RayServiceProvider registers a blade listener which is not supported by Lumen. A check if it is loaded could resolve this

If I have enough time later on I will create a pull request to resolve this, but it would be nice to hear your opinion regarding Lumen support within this package.

@freekmurze
Copy link
Member

If there are not too much code changes, I would consider merging in your PR. Thanks for your time you spend on this.

@freekmurze
Copy link
Member

Closing this for now, if you have questions around this, feel free to continue the conversation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants