Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lumen #22

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Add support for Lumen #22

merged 2 commits into from
Jan 7, 2021

Conversation

chris-doehring
Copy link
Collaborator

Related to #8, this pull request adds support for Lumen.

@chris-doehring
Copy link
Collaborator Author

There are also two things I have noticed in the configuration documentation:

  • The first array is missing a ; at the end
  • The host of the Laravel configuration should not contain http:// as this is being added by the Client class

@freekmurze
Copy link
Member

The first array is missing a ; at the end

I seem to be unable to see that 🙂 Could you send a PR to fix that. You can use the edit button on top of the page.

@chris-doehring
Copy link
Collaborator Author

The first array is missing a ; at the end

I seem to be unable to see that 🙂 Could you send a PR to fix that. You can use the edit button on top of the page.

Oh, and I haven't seen that edit button :D Will do that!

@freekmurze freekmurze merged commit b87c892 into spatie:master Jan 7, 2021
@freekmurze
Copy link
Member

Thanks!

@chris-doehring chris-doehring deleted the feature/lumen-support branch January 7, 2021 20:53
@da-sie da-sie mentioned this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants