Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implicit nullable param to explicit (PHP 8.4 compatibility) #340

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Make implicit nullable param to explicit (PHP 8.4 compatibility) #340

merged 1 commit into from
Apr 11, 2024

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Apr 10, 2024

Implicitly nullable parameter declarations are deprecated in PHP 8.4 (ref).

@freekmurze freekmurze merged commit b8c8ff9 into spatie:main Apr 11, 2024
30 checks passed
@freekmurze
Copy link
Member

Thanks!

@GromNaN GromNaN deleted the explicit-nullable branch April 11, 2024 13:31
@GromNaN
Copy link
Contributor Author

GromNaN commented Apr 11, 2024

Thank you for your quick merge. I'd be thrilled if you could do a release.

@freekmurze
Copy link
Member

Be thrilled 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants