Feature: Aspect Search Result Limit #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds an aspect limiter to apply to each aspect before queries are executed.
Adding readme for aspect limiter
I think it's easier to understand we're limiting the results not the number of aspects itself.
Fixing readme
Closed
marcorivm
suggested changes
Oct 28, 2020
There was a problem hiding this comment.
Saw this PR while searching for this functionality today, thanks for putting in the work @WalrusSoup
I think there is a function name change you could apply so it's on the same formatting as the other files like
laravel-searchable/src/SearchResult.php
Line 28 in 93a5d19
| @@ -23,4 +26,9 @@ public function getType(): string | |||
|
|
|||
| return Str::plural($type); | |||
| } | |||
|
|
|||
| public function limit($limit) : void | |||
There was a problem hiding this comment.
Suggested change
| public function limit($limit) : void | |
| public function setLimit($limit) : void |
I think it would be a good idea to use setLimit to keep consistency, see:
laravel-searchable/src/SearchResult.php
Line 28 in 93a5d19
| public function limitAspectResults(int $limit) : self | ||
| { | ||
| collect($this->getSearchAspects())->each(function(SearchAspect $aspect) use ($limit) { | ||
| $aspect->limit($limit); |
There was a problem hiding this comment.
Suggested change
| $aspect->limit($limit); | |
| $aspect->setLimit($limit); |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to add a limit to the number of results returned by each searchAspect by applying a limit on the query before execution. I'm introducing this to solve #56
Usage:
(->setAspectLimit(2)yieldslimit 2added to queries)