Webhook response customisation

[gdebrauwer]

This PR is inspired by the PR #44.

It allows you to customize the webhook response. This makes it possible to use this package in situations where a special webhook response is needed.

[freekmurze]

Thank you for this quality PR. I very much like this clean implementation 👍

I only got one nitpick. What do you think about adding a Response return type?

[freekmurze]

Thank you!

[gdebrauwer]

@freekmurze Should this not have been tagged as a new major version? 🤔It's not an issue for me, but maybe for others that update their composer packages without knowing about this new, required config-field?

[freekmurze]

The config in your app will be merged with the one in the package

laravel-webhook-client/src/WebhookClientServiceProvider.php

Line 59 in ac10182

$this->mergeConfigFrom(__DIR__.'/../config/webhook-client.php', 'webhook-client');

So this shouldn't be a breaking change for people that already have the package installed.

[gdebrauwer]

I just tested this, and it does not seem to merge the config, probably because the config-file is a list of arrays (I think)

[freekmurze]

Does this fix it for you? d21404f

(thanks for bringing this problem to my attention)

[gdebrauwer]

No, it's fixed if I do the following:

use Spatie\WebhookClient\WebhookResponse\DefaultRespondsTo;

$webhookResponseClass = $properties['webhook_response'] ?? DefaultRespondsTo::class;
if (! is_subclass_of($webhookResponseClass, RespondsToWebhook::class)) {
    throw InvalidConfig::invalidWebhookResponse($webhookResponseClass);
}
$this->webhookResponse = app($webhookResponseClass);

[freekmurze]

Could you send a quick PR for that?

[gdebrauwer]

Yes 👍